This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR gas/10704: as segfault in memory lookup intel syntax
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sources dot redhat dot com, jbeulich at novell dot com
- Date: Thu, 1 Oct 2009 17:31:43 +0930
- Subject: Re: PATCH: PR gas/10704: as segfault in memory lookup intel syntax
- References: <20090930190152.GA8220@lucon.org> <20090930191121.GA19895@lucon.org>
On Wed, Sep 30, 2009 at 12:11:21PM -0700, H.J. Lu wrote:
> On Wed, Sep 30, 2009 at 12:01:52PM -0700, H.J. Lu wrote:
> > Hi,
> >
> > LOCAL_SYMBOL_CHECK may change its argument to converted local symbol.
> > snapshot_symbol isn't prepared to deal with it. This patch fixes it.
> > OK to install?
> >
>
> Here is the updated version.
I believe the segfault is caused by your change for PR2117. Instead
of adding another hack to snapshot_symbol, I think it would be better
to revert your PR2117 snapshot_symbol change and fix PR2117 in
expr.c:resolve_expression.
--
Alan Modra
Australia Development Lab, IBM