This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR gas/10704: as segfault in memory lookup intel syntax
On Mon, Oct 5, 2009 at 3:12 PM, Alan Modra <amodra@bigpond.net.au> wrote:
> On Mon, Oct 05, 2009 at 01:59:08PM +0200, Tristan Gingold wrote:
>> So, for the release you propose to revert PR2127 and to add .cfi_sections
>> patch.
>> I will do a new pre-release with that.
>
> I have applied the following to mainline, which fixes PR10704 and the
> wrong use of expression_and_evaluate I found in s_reloc. ?I don't
> think this is acceptable for a release, unless you don't care about
> ia64. ?Jan, do you have any comments on
> http://sourceware.org/ml/binutils/2009-10/msg00093.html ?
>
> ? ? ? ?PR gas/10704
> ? ? ? ?* symbols.c (snapshot_symbol): Revert 2006-01-09 patch for PR2117.
>
> ? ? ? ?* read.c (s_reloc): Don't use expression_and_evaluate.
>
I am checking in this patch to add 2 tests.
Thanks.
--
H.J.
--
Index: ChangeLog
===================================================================
--- ChangeLog (revision 7132)
+++ ChangeLog (working copy)
@@ -1,3 +1,9 @@
+2009-10-07 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR gas/10704
+ * gas/i386/intelok.s: Add 2 new tests.
+ * gas/i386/intelok.d: Updated.
+
2009-10-02 Peter Bergner <bergner@vnet.ibm.com>
* gas/ppc/476.s: New test.
Index: gas/i386/intelok.d
===================================================================
--- gas/i386/intelok.d (revision 7132)
+++ gas/i386/intelok.d (working copy)
@@ -204,4 +204,6 @@ Disassembly of section .text:
[ ]*[0-9a-f]+: ea 03 00 00 00 05 00[ ]+l?jmp[ ]+0x5[,:]0x3
[ ]*[0-9a-f]+: ff 15 00 00 00 00[ ]+call[ ]+DWORD PTR (ds:)?(0x)?0
[ ]*[0-9a-f]+: 66 ff 25 00 00 00 00[ ]+jmp[ ]+WORD PTR (ds:)?(0x)?0
+[ ]*[a-f0-9]+: ff 24 85 3c 05 00 00 jmp DWORD PTR \[eax\*4\+0x53c\]
+[ ]*[a-f0-9]+: 8d 83 4a 05 00 00 lea eax,\[ebx\+0x54a\]
#pass
Index: gas/i386/intelok.s
===================================================================
--- gas/i386/intelok.s (revision 7132)
+++ gas/i386/intelok.s (working copy)
@@ -216,5 +216,7 @@ start:
call dword ptr xtrn
jmp word ptr xtrn
- # Force a good alignment.
- .p2align 4,0
+.L11:
+ jmp DWORD PTR[ .L11 + eax * 4 ]
+.LC0:
+ lea eax, DWORD PTR[ .LC0@GOTOFF + ebx ]