This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH GOLD] [6/N mingw host] Add support for not keeping the files open on execute
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: gcgb-binutils at lo dot gmane dot org
- Cc: Andrew Pinski <Andrew_Pinski at playstation dot sony dot com>, binutils <binutils at sourceware dot org>
- Date: Thu, 08 Oct 2009 01:35:45 +0100
- Subject: Re: [PATCH GOLD] [6/N mingw host] Add support for not keeping the files open on execute
- References: <de8d50360910071221n3a4a172ag61d4fd4940ce7fcd@mail.gmail.com> <4ACCF35E.8020207@lo.gmane.org>
gcgb-binutils wrote:
> Andrew Pinski wrote:
>> This is the first patch which I could not figure out how to do without
>> a #ifdef _WIN32.
>
> This may break cygwin (that is, it may unintentionally cause a gold
> built on a cygwin $host to use win32 constructs directly, instead of
> going thru the cygwin posix emulation).
Oh, good catch!
> If you really truly want a block of code
> to be active ONLY if mingw, then it's best to use:
>
> #if defined(_WIN32) && !defined(__CYGWIN__)
Any reason why not just "#ifdef __MINGW32__" for that case?
> And, if you want a block of code to be active on the windows platform,
> regardless of whether its mingw or cygwin, then
>
> #if defined(_WIN32) || defined(__CYGWIN__)
Likewise. After all, that one will theoretically also catch MSVC, CE and
Interix, won't it? :-P
cheers,
DaveK