This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [COMMITTED PATCH] Fix %s that should be %B in several message formats.

From: Roland McGrath <roland at redhat dot com>
To: Alan Modra <amodra at bigpond dot net dot au>
Cc: binutils at sourceware dot org
Date: Tue, 13 Oct 2009 11:18:20 -0700 (PDT)
Subject: Re: [COMMITTED PATCH] Fix %s that should be %B in several message formats.
References: <20091013023617.A8859A8C0@magilla.sf.frob.com> <20091013031448.GG8054@bubble.grove.modra.org>

> Your patch is obviously incorrect, except for the last place you
> change.  Please fix.

That last place was the actual one I had noticed and (knew how to) test.
I'm confused about how the other cases I changed differ from that one.
They pass a bfd * argument to (*_bfd_error_handler) first after the format,
corresponding to a %s in the format.


Thanks,
Roland

Follow-Ups:
- Re: [COMMITTED PATCH] Fix %s that should be %B in several message formats.
  - From: Dave Korn
- Re: [COMMITTED PATCH] Fix %s that should be %B in several message formats.
  - From: Alan Modra

References:
- [COMMITTED PATCH] Fix %s that should be %B in several message formats.
  - From: Roland McGrath
- Re: [COMMITTED PATCH] Fix %s that should be %B in several message formats.
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]