This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [COMMITTED PATCH] Fix %s that should be %B in several message formats.

From: Alan Modra <amodra at bigpond dot net dot au>
To: Roland McGrath <roland at redhat dot com>
Cc: binutils at sourceware dot org
Date: Wed, 14 Oct 2009 10:09:59 +1030
Subject: Re: [COMMITTED PATCH] Fix %s that should be %B in several message formats.
References: <20091013023617.A8859A8C0@magilla.sf.frob.com> <20091013031448.GG8054@bubble.grove.modra.org> <20091013181820.36FDCAA4@magilla.sf.frob.com>

On Tue, Oct 13, 2009 at 11:18:20AM -0700, Roland McGrath wrote:
> > Your patch is obviously incorrect, except for the last place you
> > change.  Please fix.
> 
> That last place was the actual one I had noticed and (knew how to) test.
> I'm confused about how the other cases I changed differ from that one.
> They pass a bfd * argument to (*_bfd_error_handler) first after the format,
> corresponding to a %s in the format.

_bfd_default_error_handler is out to get you. :-)  Incidentally, my
"obviously incorrect" comment refers to the fact that your patch
resulted in all the format specs being %B but one of the args
remaining a string.  I should have explained, sorry.

-- 
Alan Modra
Australia Development Lab, IBM

Follow-Ups:
- Re: [COMMITTED PATCH] Fix %s that should be %B in several message formats.
  - From: Roland McGrath

References:
- [COMMITTED PATCH] Fix %s that should be %B in several message formats.
  - From: Roland McGrath
- Re: [COMMITTED PATCH] Fix %s that should be %B in several message formats.
  - From: Alan Modra
- Re: [COMMITTED PATCH] Fix %s that should be %B in several message formats.
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]