This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: binutils 2.20 release (soon)


Alan Modra wrote:
On Wed, Oct 14, 2009 at 11:24:58PM +0200, Vincent Rivière wrote:
The gas tests fail because they expect ELF relocations like R_68K_PC16, but the m68k-netbsd uses a.out relocations like DISP16.

Similar problem with the binutils test: the source file contains special section specifications, unsupported by a.out

Patches welcome. ;-)

Here is my patch. It disables the irrelevant tests on specific a.out targets. I tested it only on m68k-netbsd target.

The only remaining test failing on m68k-netbsd is copy-4 from PR 9933:
http://sourceware.org/bugzilla/show_bug.cgi?id=9933

I believe the test is good but the fix does not work for a.out.

--
Vincent Rivière
diff -aurN binutils-2.20/binutils/testsuite/binutils-all/copy-2.d binutils-2.20-netbsd/binutils/testsuite/binutils-all/copy-2.d
--- binutils-2.20/binutils/testsuite/binutils-all/copy-2.d	2009-10-16 20:30:42.156250000 +0200
+++ binutils-2.20-netbsd/binutils/testsuite/binutils-all/copy-2.d	2009-10-16 23:16:28.765625000 +0200
@@ -3,7 +3,7 @@
 #objcopy: --set-section-flags foo=contents,alloc,load,code
 #name: copy with setting section flags 2
 #source: copytest.s
-#not-target: *-*-*aout
+#not-target: *-*-*aout m68k-*-netbsd m68k-*-openbsd* ns32k-*-netbsd
 # Note - we use copytest.s and a section named "foo" rather
 # than .text because for some file formats (eg PE) the .text
 # section has a fixed set of flags and these cannot be changed.
diff -aurN binutils-2.20/binutils/testsuite/binutils-all/copy-3.d binutils-2.20-netbsd/binutils/testsuite/binutils-all/copy-3.d
--- binutils-2.20/binutils/testsuite/binutils-all/copy-3.d	2009-10-16 20:30:42.156250000 +0200
+++ binutils-2.20-netbsd/binutils/testsuite/binutils-all/copy-3.d	2009-10-16 22:22:06.125000000 +0200
@@ -3,7 +3,7 @@
 #objcopy: --set-section-flags .text=alloc,data
 #name: copy with setting section flags 3
 #source: bintest.s
-#not-target: *-*-*aout *-*-*pe *-*-*coff i*86-*-cygwin* i*86-*-mingw32* x86_64-*-mingw*
+#not-target: *-*-*aout *-*-*pe *-*-*coff i*86-*-cygwin* i*86-*-mingw32* m68k-*-netbsd m68k-*-openbsd* x86_64-*-mingw*
 # The .text # section in PE/COFF has a fixed set of flags and these
 # cannot be changed.  We skip it for them.
 
diff -aurN binutils-2.20/gas/testsuite/gas/all/weakref1u.d binutils-2.20-netbsd/gas/testsuite/gas/all/weakref1u.d
--- binutils-2.20/gas/testsuite/gas/all/weakref1u.d	2009-10-16 20:30:46.750000000 +0200
+++ binutils-2.20-netbsd/gas/testsuite/gas/all/weakref1u.d	2009-10-16 22:11:38.562500000 +0200
@@ -3,7 +3,7 @@
 #source: weakref1.s
 # aout turns undefined into *ABS* symbols.
 # see weakref1.d for comments on the other not-targets
-#not-target: *-*-*aout ns32k-*-netbsd alpha*-*-osf* *-*-ecoff
+#not-target: *-*-*aout m68k-*-netbsd m68k-*-openbsd* ns32k-*-netbsd alpha*-*-osf* *-*-ecoff
 
 # the rest of this file is generated with the following script:
 # # script begin
diff -aurN binutils-2.20/gas/testsuite/gas/m68k/br-isaa.d binutils-2.20-netbsd/gas/testsuite/gas/m68k/br-isaa.d
--- binutils-2.20/gas/testsuite/gas/m68k/br-isaa.d	2009-10-16 20:30:53.546875000 +0200
+++ binutils-2.20-netbsd/gas/testsuite/gas/m68k/br-isaa.d	2009-10-16 22:10:34.625000000 +0200
@@ -1,6 +1,7 @@
 #name: br-isaa.d
 #objdump: -dr
 #as: -march=isaa -pcrel
+#not-target: *-*-*aout m68k-*-netbsd m68k-*-openbsd*
 
 .*:     file format .*
 
diff -aurN binutils-2.20/gas/testsuite/gas/m68k/br-isab.d binutils-2.20-netbsd/gas/testsuite/gas/m68k/br-isab.d
--- binutils-2.20/gas/testsuite/gas/m68k/br-isab.d	2009-10-16 20:30:53.546875000 +0200
+++ binutils-2.20-netbsd/gas/testsuite/gas/m68k/br-isab.d	2009-10-16 22:14:17.546875000 +0200
@@ -1,6 +1,7 @@
 #name: br-isab.d
 #objdump: -dr
 #as: -march=isab -pcrel
+#not-target: *-*-*aout m68k-*-netbsd m68k-*-openbsd*
 
 .*:     file format .*
 
diff -aurN binutils-2.20/gas/testsuite/gas/m68k/br-isac.d binutils-2.20-netbsd/gas/testsuite/gas/m68k/br-isac.d
--- binutils-2.20/gas/testsuite/gas/m68k/br-isac.d	2009-10-16 20:30:53.546875000 +0200
+++ binutils-2.20-netbsd/gas/testsuite/gas/m68k/br-isac.d	2009-10-16 22:14:12.828125000 +0200
@@ -1,6 +1,7 @@
 #name: br-isac.d
 #objdump: -dr
 #as: -march=isac -pcrel
+#not-target: *-*-*aout m68k-*-netbsd m68k-*-openbsd*
 
 .*:     file format .*
 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]