This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] New ia64 @slotcount pseudo func (3rd try)
- From: Nick Clifton <nickc at redhat dot com>
- To: Douglas B Rupp <rupp at gnat dot com>
- Cc: Alan Modra <amodra at bigpond dot net dot au>, Jan Beulich <JBeulich at novell dot com>, Richard Henderson <rth at redhat dot com>, binutils at sourceware dot org, Tristan Gingold <gingold at adacore dot com>
- Date: Thu, 05 Nov 2009 12:01:14 +0000
- Subject: Re: [PATCH] New ia64 @slotcount pseudo func (3rd try)
- References: <4AF1DB04.5030804@gnat.com>
Hi Douglas,
There's been alot of comments on this patch and I appreciate everyone's
time in making them.
Guess what - I have a few more, very minor, changes that I would like to
see in the patch. These are mostly formatting issues, but it would be
nice to see them fixed:
+#ifdef TE_VMS
+ /* expression pseudo functions: */
Comment formatting - the comment should be treated as a sentence and
start with a capital letter. (I do realize that the other comments in
this part of the code are formatted in the same way as your comment, but
they are also wrong and should be fixed one day).
+ if (*input_line_pointer++ != '-')
+ {
Indentation - the opening curly brace, (and the code that follows),
should be indented by two more spaces.
+ as_bad ("invalid @slotcount expression");
Internationalization - the error message should be enclosed in _(....).
+ val = (((end & -16) - (beg & -16)) / 16 * 3)
+ + (end & 15)
+ - (beg & 15);
Just a suggestion here - this expression seems rather complex and
non-intuitive. Maybe a comment describing how the computation works
would be useful for future readers of the code.
Cheers
Nick