This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix build error on OSX

From: Masaki Muranaka <monaka at monami-software dot com>
To: Alan Modra <amodra at bigpond dot net dot au>
Cc: binutils at sourceware dot org
Date: Fri, 6 Nov 2009 13:47:57 +0900
Subject: Re: Fix build error on OSX
References: <D32CF5E3-EE9C-410E-A684-08511EB73D42@monami-software.com> <20091105231706.GC7742@bubble.grove.modra.org>

Hello Alan,

Why are you concluding I didn't test? ;-)

I've tested on Debian Lenny (host,build.target=x86_64-unknown-linux-gnu) and there seems be no side effect.

Of course I've tested on Snow Leopard (host,build.target=x86_64-apple-darwin10.0.0)
The one build is patched. The another build is commented out HAVE_STAT64 by hand.
The results of "make check-binutils" are same.

I found some unexpected failures in each results but they are not caused by my patch. 

On 2009/11/06, at 8:17, Alan Modra wrote:

> On Thu, Nov 05, 2009 at 01:58:33PM +0900, Masaki Muranaka wrote:
>> My patch is attached. Could someone review this?
>
> Why are you posting patches that you haven't tested?
>
> -- 
> Alan Modra
> Australia Development Lab, IBM
>

Follow-Ups:
- Re: Fix build error on OSX
  - From: Alan Modra

References:
- Fix build error on OSX
  - From: Masaki Muranaka
- Re: Fix build error on OSX
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]