This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, CFI] Fix EH for coldfire-uclinux


Daniel Jacobowitz wrote:
On Wed, Nov 04, 2009 at 10:07:28AM -0800, Richard Henderson wrote:
On 11/03/2009 01:35 PM, Maxim Kuvyrkov wrote:
To generate bFLT binaries for coldfire-uclinux elf2flt utility is used.
Elf2flt does not honor PT_LOAD's from the executable. So, despite
appearances of the ELF file, .text and .eh_frame sections will not end
up in the same segment in bFLT file. Therefore PC-relative encoding
cannot be used for CFI on coldfire-uclinux. Hence this patch defines
CFI_DIFF_EXPR_OK to 0 for coldfire-uclinux.
I don't see anything wrong with the patch as far as it goes, but...

That's good enough for me (for now) - Maxim, the patch can go in.

This patch is now checked in.


Thanks for all the review,

--
Maxim Kuvyrkov
CodeSourcery
maxim@codesourcery.com
(650) 331-3385 x724


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]