Re: [patch] Add bfd_target_info function to bfd and unify windres/windmc target information gathering

[Dave Korn <dave dot korn dot cygwin at googlemail dot com>]

Kai Tietz wrote:

> Tested for i686-pc-mingw32, i686-pc-cygwin, and x86_64-pc-mingw32. Ok for apply?

  No objections from the PE point of view (disclaimer: didn't build or test
the patch myself), but wait for Nick to OK the global changes to bfd.  Few
formatting nits:

> +const bfd_target * bfd_get_target_info (const char *target_name, bfd *abfd,

  Space before the * but not after, like bfd_find_target above.

> +_bfd_find_arch_match (const char *tname,const char **arch,

  Space needed before second 'const'.

> +	If @var{is_bigendian} is not <<NULL>>, then set this value to target's
> +	endian mode. One for big-endian, zero for little-endian, and -1 for
> +	invalid target.

  This is not what the code actually does, since is_bigendian is a bfd_boolean
rather than an int type.  I'd suggest you just change the documentation to say
that it defaults to false for invalid target rather than change the type,
there are enough other ways for the caller to know that the target was not valid.

+	      /* Make sure we dectect architecture names

  Typo "dectect" -> "detect".

    cheers,
      DaveK