This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: GOLD:PATCH: Treat STB_GNU_UNIQUE as STB_GLOBAL
- From: Ian Lance Taylor <iant at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 04 Dec 2009 21:57:55 -0800
- Subject: Re: GOLD:PATCH: Treat STB_GNU_UNIQUE as STB_GLOBAL
- References: <20091205022356.GA21156@lucon.org>
"H.J. Lu" <hongjiu.lu@intel.com> writes:
> 2009-12-04 H.J. Lu <hongjiu.lu@intel.com>
>
> * resolve.cc: Fix typo in comment.
> (symbol_to_bits): Treat STB_GNU_UNIQUE as STB_GLOBAL.
> (Symbol_table::override_with_special): Likewise.
> (Symbol_table::add_from_object): Likewise.
> --- a/gold/resolve.cc
> +++ b/gold/resolve.cc
> @@ -151,7 +151,7 @@ Symbol_table::override(Sized_symbol<size>* tosym,
> // Bit 0: 0 for global, 1 for weak.
> // Bit 1: 0 for regular object, 1 for shared object
> // Bits 2-3: 0 for normal, 1 for undefined, 2 for common
> -// This gives us values from 0 to 11.
> +// This gives us values from 0 to 15.
This change is incorrect. Note that bits 2-3 never take the value 3.
Please do not commit this, nor the corresponding ChangeLog entry.
The rest of the patch is OK.
Thanks.
Ian