Re: PATCH: Support --enable-gold=both --enable-linker=[bfd|gold]

[Ian Lance Taylor <iant at google dot com>]

"H.J. Lu" <hjl.tools@gmail.com> writes:

> On Tue, Nov 3, 2009 at 2:19 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Mon, Nov 2, 2009 at 3:06 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>>> Hi,
>>>
>>> This patch adds --enable-gold=both --with-linker=[bfd|gold] so that we
>>> can build both ld and gold. This patch will
>>>
>>> 1. Install ld as ld.bfd
>>> 2. Install gold as ld.gold
>>> 3. Install one of them as ld, selected by --with-linker.
>>>
>>> If needed, gcc install invoke gold as ld.gold and ld as ld.bfd. ÂAny
>>> comments?
>>>
>>
>> Here is the updated patch. It installs ld.bfd/ld.gold only if both
>> linkers are enabled.
>>
>>
>
> Here is the updated patch. OK to install?


For the record, I'm OK with this patch.  I don't plan to approve it
myself though.

Ian


> 2009-11-03  Roland McGrath  <roland@redhat.com>
> 	    H.J. Lu  <hongjiu.lu@intel.com>
>
> 	* configure.ac (--enable-gold): Accept --enable-gold=both to
> 	add gold to configdirs without removing ld.
> 	* configure: Regenerated.
>
> gold/
>
> 2009-11-03  H.J. Lu  <hongjiu.lu@intel.com>
>
> 	* Makefile.am (install-exec-local): Install as @installed_linker@.
> 	Install as ld if "@linker@" == "ld.gold" and @installed_linker@
> 	!= "ld".
> 	* Makefile.in: Regenerated.
>
> 	* configure.ac (installed_linker): New substituted variable.  Set
> 	by --enable-gold.
> 	(linker): New substituted variable.  Set by --enable-gold and
> 	--enable-linker.
> 	* configure: Regenerated.
>
> ld/
>
> 2009-11-03  H.J. Lu  <hongjiu.lu@intel.com>
>
> 	* Makefile.am (transform): Install as @installed_linker@.
> 	(install-exec-local): Depend on install-binPROGRAMS.  Install
> 	as @installed_linker@.  Install as ld if "@linker@" == "ld.bfd"
> 	and @installed_linker@ != "ld".
> 	* Makefile.in: Regenerated.
>
> 	* configure.ac (installed_linker): New substituted variable.  Set
> 	by --enable-gold.
> 	(linker): New substituted variable.  Set by --enable-gold and
> 	--enable-linker.
> 	* configure: Regenerated.
>
> 2009-11-03  Roland McGrath  <roland@redhat.com>
> 	    H.J. Lu  <hongjiu.lu@intel.com>
>
> 	* configure.ac (--enable-gold): Accept --enable-gold=both to
> 	add gold to configdirs without removing ld.
> 	* configure: Regenerated.
>
> gold/
>
> 2009-11-03  H.J. Lu  <hongjiu.lu@intel.com>
>
> 	* Makefile.am (install-exec-local): Install as @installed_linker@.
> 	Install as ld if "@linker@" == "ld.gold" and @installed_linker@
> 	!= "ld".
> 	* Makefile.in: Regenerated.
>
> 	* configure.ac (installed_linker): New substituted variable.  Set
> 	by --enable-gold.
> 	(linker): New substituted variable.  Set by --enable-gold and
> 	--enable-linker.
> 	* configure: Regenerated.
>
> ld/
>
> 2009-11-03  H.J. Lu  <hongjiu.lu@intel.com>
>
> 	* Makefile.am (transform): Install as @installed_linker@.
> 	(install-exec-local): Depend on install-binPROGRAMS.  Install
> 	as @installed_linker@.  Install as ld if "@linker@" == "ld.bfd"
> 	and @installed_linker@ != "ld".
> 	* Makefile.in: Regenerated.
>
> 	* configure.ac (installed_linker): New substituted variable.  Set
> 	by --enable-gold.
> 	(linker): New substituted variable.  Set by --enable-gold and
> 	--enable-linker.
> 	* configure: Regenerated.