This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix build breakages on OSX due to -Wshadow and use of mempcpy.
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Doug Kwan (éæå) <dougkwan at google dot com>
- Cc: binutils <binutils at sourceware dot org>, Nick Clifton <nickc at redhat dot com>
- Date: Tue, 15 Dec 2009 10:32:10 +1030
- Subject: Re: [PATCH] Fix build breakages on OSX due to -Wshadow and use of mempcpy.
- References: <498552560912141211t496f749eka50acdb1e0b0f622@mail.gmail.com>
On Mon, Dec 14, 2009 at 12:11:33PM -0800, Doug Kwan (éæå) wrote:
> 2009-12-14 Doug Kwan <dougkwan@google.com>
>
> bfd/ChangeLog:
>
> * bfd-in2.h (bfd_opnr_iovec): Rename parameters to avoid shawdowed
> declaration warnings.
>
> gas/ChangeLog:
>
> * config/tc-i386.c (show_arch): Replace uses of mempcpy with
> equivalent code sequences with memcpy for portability.
>
> include/ChangeLog:
>
> * bfdlink.h (struct bfd_link_callbacks): Rename function parameters
> to avoid shadowed declaration warnings.
> * dis-asm.h (struct disassemble_info): Ditto.
> (disassemble_init_for_target): Ditto.
> (init_disassemble_info): Ditto.
The patch is OK except that bfd-in2.h is a generated file. Apply your
changes to opncls.c instead.
--
Alan Modra
Australia Development Lab, IBM