This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] ARM Disassembler fix
- From: Pedro Alves <pedro at codesourcery dot com>
- To: binutils at sourceware dot org
- Cc: Daniel Gutson <dgutson at codesourcery dot com>, Nick Clifton <nickc at redhat dot com>, Paul Brook <paul at codesourcery dot com>
- Date: Tue, 5 Jan 2010 12:48:59 +0000
- Subject: Re: [PATCH] ARM Disassembler fix
- References: <4B394175.2080100@codesourcery.com> <4B3C9117.2000305@redhat.com> <4B4252F1.3020408@codesourcery.com>
On Monday 04 January 2010 20:43:29, Daniel Gutson wrote:
> Hi Nick,
>
> Nick Clifton wrote:
> > Hi Daniel,
> >
> >> The attached patch fixes a bug that causes the disassembler to dump
> >> code when it should dump data.
> >
> > This looks wrong to me. Why should the disassembler assume that, in the
> > absence of mapping symbols to guide it, the .text section contains data
> > rather than instructions ? Surely it is more likely to contain
> > instructions and it is merely that the mapping symbols are absent ?
> Please refer to the AAELF, i.e. IHI0044D pp 23, @4.6.5.1, e.g.
> "A section must have a mapping symbol defined at the beginning of the
> section; however, if the section contains only data then the mapping
> symbol may be omitted."
The patch breaks text disassembly on arm non-elf targets. Could
this be restrict to elf, please?
--
Pedro Alves