This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD][PATCH] Added support for R_ARM_V4BX relocation
I would use DEFINE_special to define both --fix-v4bx and
--fix-v4bx-interworking and have code in
General_options::parse_fix_v4bx() and
General_options::parse_fix_v4bx_interworking() updating a single
switch.
-Doug
2010/1/11 Viktor Kutuzov <vkutuzov@accesssoftek.com>:
>> Can you add ld-compatible command line switches at least to turn this on and off?
>
> We will need one ld-compatible command line switch to turn this on and off, and another one for interworking.
> And that's exactly what I wanted to discuss.
>
> As it is now, I don't see an easy and "right" way to add target-specific switches.
>
> Ian, do you have a picture in mind of how to support target-specific switches in gold?
> Would you share it, please?
>
>> If I were you, I would create a new sub ...
>
> Thanks Doug.
> That's how I planned to do that after the target-specific switches implementation will be decided.
>
> -Viktor
>
> ________________________________________
> From: Doug Kwan (Ãö®¶¼w) [dougkwan@google.com]
> Sent: Monday, January 11, 2010 4:54 PM
> To: Viktor Kutuzov
> Cc: Ian Lance Taylor; binutils@sourceware.org
> Subject: Re: [GOLD][PATCH] Added support for R_ARM_V4BX relocation
>
> I cannot approve but I have some comments. The sort of works but I am
> not sure if we want it to be always enabled. Can you add
> ld-compatible command line switches at least to turn this on and off?
>
> Adding interworking support is not difficult as all the
> infrastructures are in place. If I were you, I would create a new sub
> class V4bx_stub of the Stub class to represent the v4bx stubs. You
> need to add one new stub template as far as I can see. I would also
> add a vector in Stub_table to hold these V4bx_stub since there are
> only a small fixed number of possible stubs The stub table class
> already handles both relocation stubs and cortex-A8 stub. So it is
> quite straight forward to add another support stub type. You can look
> at arm_branch_common to see how we redirect a branch to a stub.
>
> -Doug
>
> 2010/1/11 Viktor Kutuzov <vkutuzov@accesssoftek.com>:
>> Hello everyone,
>>
>> Please find attached a patch that adds a support for R_ARM_V4BX relocation.
>>
>> It supports the instruction replacement only, no interworking yet.
>> The interworking for R_ARM_V4BX is to be discussed.
>>
>> Best regards,
>> Viktor
>>
>> * gold/arm.cc: Added support for R_ARM_V4BX relocation