This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD][PATCH] Refactor THUMB branch encoding code to avoid code duplication.
- From: Ian Lance Taylor <iant at google dot com>
- To: Doug Kwan (éæå) <dougkwan at google dot com>
- Cc: binutils <binutils at sourceware dot org>
- Date: Mon, 11 Jan 2010 22:00:35 -0800
- Subject: Re: [GOLD][PATCH] Refactor THUMB branch encoding code to avoid code duplication.
- References: <498552561001111849s491f9737ue14173faad67a5b1@mail.gmail.com>
"Doug Kwan (éæå)" <dougkwan@google.com> writes:
> 2010-01-11 Doug Kwan <dougkwan@google.com>
>
> * arm.cc (Arm_relocate_functions::thumb32_branch_offset,
> Arm_relocate_functions::thumb32_branch_upper,
> Arm_relocate_functions::thumb32_branch_lower,
> Arm_relocate_functions::thumb32_cond_branch_offset,
> Arm_relocate_functions::thumb32_cond_branch_upper,
> Arm_relocate_functions::thumb32_cond_branch_lower,
> Arm_relocate_functions::thm_jump19): New methods to handle THUMB
> branch offset encoding.
> (Arm_relocate_functions::thumb_branch_common): Use new branch
> offset encoding methods to avoid code duplication.
> (Stub_template::Stub_template) Handle THUMB16_SPECIAL_TYPE.
> (Stub_addend_reader::operator()): Use new branch encoding method
> to avoid code duplication.
This is OK.
Thanks.
Ian