This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Make .eh_frame sections read-only on 64-bit Solaris/x86


Hi Rainer,

2010-01-18 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>

	* config/te-solaris.h (DWARF2_EH_FRAME_READ_ONLY): Make read-only
	on 64-bit Solaris/x86.

Approved - please apply - but, please could you extend the comment slightly:


  /* The Sun linker doesn't merge read-only and read-write sections into
     a single read-write section so we must force all EH frame sections
     to be read-write on SPARC and 32-bit i386.  */

to:

  /* The Sun linker doesn't merge read-only and read-write sections into
     a single section so we must force all EH frame sections to use the
     same flags.  For SPARC and 32-bit i386 this is read-write, whilst
     for x86_64 this is read-only (because that is how gcc does it).  */

Or something similar. (Ideally it would be nice to include the URL for the start of this thread as well, so that interested readers could find out why the flags are different for 32-bit and 64-bit sparcs. But you
might think that this is overkill. Your call).


Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]