This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch/RFA]: Patch to fix R_ARM_THM_JUMP24 relocation truncated bug
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: Christophe LYON <christophe dot lyon at st dot com>, binutils at sourceware dot org, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
- Date: Wed, 03 Feb 2010 13:41:21 +0000
- Subject: Re: [Patch/RFA]: Patch to fix R_ARM_THM_JUMP24 relocation truncated bug
- References: <1263477671.28149.21.camel@cam-bc3-b12.cambridge.arm.com> <20100115003439.GE8112@bubble.grove.modra.org> <1263825396.18030.17.camel@cam03638.cambridge.arm.com> <20100119040211.GI8112@bubble.grove.modra.org> <1264420828.2057.13.camel@cam-bc5-b9.cambridge.arm.com> <4B67F3E4.7060602@st.com> <1265120565.30386.36.camel@e102111-lin.cambridge.arm.com>
On Tue, 2010-02-02 at 14:22 +0000, Matthew Gretton-Dann wrote:
> Hi,
>
> On Tue, 2010-02-02 at 10:44 +0100, Christophe LYON wrote:
> > > 2010-01-18 Matthew Gretton-Dann<matthew.gretton-dann@arm.com>
> > >
> > > * ld-arm/jump-reloc-veneers-long.d: New test.
> > > * ld-arm/jump-reloc-veneers-short1.d: Likewise.
> > > * ld-arm/jump-reloc-veneers-short2.d: Likewise.
> > > * ld-arm/jump-reloc-veneers.s: Likewise.
> > > * ld-arm/arm-elf.exp (armelftests): Run them.
> > >
> >
> > On a trunk extracted yesterday, I observe that all these tests fail
> > (target arm-none-eabi).
> > There seem to be a discrepancy between the start address defined as
> > -defsym _start=0x8000 in arm-elf.exp and expected to be
> > 00008054 <[^>]*>:
> > 8054: f000 bfd4 b.w 9000 <dest>
> > in jump-reloc-venners-short1.d for instance.
> >
> > Am I missing something?
>
> No - I didn't make the test cases cope with bare-metal targets properly.
>
> Please find attached a patch which corrects the test cases to work with
> arm-none-eabi as well as the other ARM targets. I have tested this on
> arm-none-eabi, arm-none-elf, arm-linux, and arm-unknown-linux-gnueabi,
> with no regressions.
>
> Please can someone review and approve the patch, and then commit? A
> suggested ChangeLog is
>
> 2010-02-02 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * ld-arm/jump-reloc-veneers-long.d: Correct testcase for
> arm-none-eabi target.
> * ld-arm/jump-reloc-veneers-short1.d: Likewise
> * ld-arm/jump-reloc-veneers-short2.d: Likewise
This is OK, but could someone else please check it in.
R.