This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch/RFA]: Patch to fix R_ARM_THM_JUMP24 relocation truncated bug


On Tue, 2010-02-02 at 14:22 +0000, Matthew Gretton-Dann wrote:
> Hi,
> 
> On Tue, 2010-02-02 at 10:44 +0100, Christophe LYON wrote:
> > > 2010-01-18  Matthew Gretton-Dann<matthew.gretton-dann@arm.com>
> > >
> > > 	* ld-arm/jump-reloc-veneers-long.d: New test.
> > > 	* ld-arm/jump-reloc-veneers-short1.d: Likewise.
> > > 	* ld-arm/jump-reloc-veneers-short2.d: Likewise.
> > > 	* ld-arm/jump-reloc-veneers.s: Likewise.
> > > 	* ld-arm/arm-elf.exp (armelftests): Run them.
> > >
> > 
> > On a trunk extracted yesterday, I observe that all these tests fail 
> > (target arm-none-eabi).
> > There seem to be a discrepancy between the start address defined as
> > -defsym _start=0x8000 in arm-elf.exp and expected to be
> > 00008054 <[^>]*>:
> >      8054:	f000 bfd4 	b.w	9000 <dest>
> > in jump-reloc-venners-short1.d for instance.
> > 
> > Am I missing something?
> 
> No - I didn't make the test cases cope with bare-metal targets properly.
> 
> Please find attached a patch which corrects the test cases to work with
> arm-none-eabi as well as the other ARM targets.  I have tested this on
> arm-none-eabi, arm-none-elf, arm-linux, and arm-unknown-linux-gnueabi,
> with no regressions.
> 
> Please can someone review and approve the patch, and then commit?  A
> suggested ChangeLog is
> 
> 2010-02-02  Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
> 
> 	* ld-arm/jump-reloc-veneers-long.d: Correct testcase for
> 	arm-none-eabi target.
> 	* ld-arm/jump-reloc-veneers-short1.d: Likewise
> 	* ld-arm/jump-reloc-veneers-short2.d: Likewise

This is OK, but could someone else please check it in.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]