This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: ARM stub sizing fix

From: Christophe LYON <christophe dot lyon at st dot com>
To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
Cc: binutils at sourceware dot org, amodra at gmail dot com
Date: Thu, 04 Feb 2010 17:37:17 +0100
Subject: Re: ARM stub sizing fix
References: <20100114115528.GA8112@bubble.grove.modra.org> <20100114141014.GA3850@caradoc.them.org> <20100114144708.GB8112@bubble.grove.modra.org> <20100114151142.GA8613@caradoc.them.org> <20100114153342.GC8112@bubble.grove.modra.org> <20100114194814.GA27448@caradoc.them.org> <20100114235333.GD8112@bubble.grove.modra.org> <4B5584C0.7070501@st.com> <1265300798.9961.40.camel@e102111-lin.cambridge.arm.com>

Hi,

The 'obvious' fix of changing the call to arm_stub_hash_lookup() made by
elf32_arm_get_stub_entry() to pass TRUE for the create parameter (around
elf32-arm.c:3324) causes the tests to 'pass' (they still fail - but only
due to stub ordering changes).  However, I do not know what other
effects it has and whether that is a safe change.  Could someone with
more knowledge of this area take a look please, and make some comments?

As I mentioned in another thread, I am currently looking at this, as Alan's patch actually triggered several bugs. In this process, I have encountered issues with an earlier patch from one of your colleagues, for which I am about to propose a patch.

Christophe.

References:
- Re: ARM stub sizing fix
  - From: Matthew Gretton-Dann

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]