This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Include sysdep.h before stdio.h in ldlex.c

From: Nick Clifton <nickc at redhat dot com>
To: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, binutils at sourceware dot org, Franz Fehringer <fehrin at t-online dot de>, Tristan Gingold <gingold at adacore dot com>, rdsandiford at googlemail dot com
Date: Wed, 10 Feb 2010 08:57:14 +0000
Subject: Re: Include sysdep.h before stdio.h in ldlex.c
References: <878wb3v7nd.fsf@firetop.home> <20100209064019.GB6879@gmx.de> <87zl3ivzu8.fsf@firetop.home>

Hi Richard,

Does this look OK to you? Nick?

I still think that you ought to have a comment in ldlex-wrapper.c explaining why it is necessary, but apart from that I have no other objections and I am happy to approve it.

Cheers
  Nick

ld/
	* Makefile.am (CFILES): Add ldlex-wrapper.c.
	(OFILES): Replace ldlex.c with ldlex-wrapper.c.
	(ldlex.o): Replace with...
	(ldlex-wrapper.o): ...this new rule.
	(EXTRA_ld_new_SOURCES): Add ldlex.l.
	(ld_new_SOURCES): Replace ldlex.l with ldlex-wrapper.c.
	* Makefile.in: Regenerate.
	* ldlex.l (sysdep.h): Don't include here.
	* ldlex-wrapper.c: New file.

Follow-Ups:
- Re: Include sysdep.h before stdio.h in ldlex.c
  - From: Richard Sandiford

References:
- Include sysdep.h before stdio.h in ldlex.c
  - From: Richard Sandiford
- Re: Include sysdep.h before stdio.h in ldlex.c
  - From: Ralf Wildenhues
- Re: Include sysdep.h before stdio.h in ldlex.c
  - From: Richard Sandiford

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]