Re: sparc TPOFF handling in GOLD

[David Miller <davem at davemloft dot net>]

From: Ian Lance Taylor <iant@google.com>
Date: Wed, 10 Feb 2010 13:34:17 -0800

> That sounds basically right to me.  Probably we should split
> is_relative_ into two fields: one which says that the reloc should use
> a symbol index of 0 and the symbol value as the addend, and one which
> says that the reloc should be sorted and counted as a RELATIVE reloc.
> Then most of the Output_reloc constructors get a new parameter.  Hmmm.

Yeah, I have a patch half-written which does this.

> Then I guess that rather than using the
> Output_data_got::add_local_with_rela helper function, that code will
> have to be done manually in sparc.cc.  That is, assign the GOT offset
> and create the reloc, as in, e.g., x86_64.cc handling of
> R_X86_64_GOTPC32_TLSDESC for a local symbol.

Right.  That's what the sparc.cc code was doing before when
it was mis-using the ->add_*_relative() with non-R_SPARC_RELATIVE
relocations.