This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH,PR11280] Ping Solaris maintainers re: fix solaris-x-windows windres tool
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 15 Feb 2010 01:10:09 +0000
- Subject: [PATCH,PR11280] Ping Solaris maintainers re: fix solaris-x-windows windres tool
Hi Solaris maintainers/interested parties,
Following on from the thread "Binutils 2.20 - Windres problems building
pthreads/libiconv on Open Solaris"(*), I have the following patch to propose
for Solaris hosts.
In PR11280, cross-mingw windres is failing, because the default code page it
uses when none is specified on the command-line has the name "MS-ANSI", which
is not known to Solaris' libc. It appears that "MS-ANSI" is a slightly
non-standard alias for "WINDOWS-1252", and this patch adds a -D option to the
solaris HDEFINES that overrides the 'default default setting' with the more
standard name.
This has already been shown to fix PR11280, but I'd like solaris folk
(nobody's listed in MAINTAINERS?) to speak up, because as written it only adds
the new define for *-*-solaris2.11. I don't have access to anything other
than an OpenSolaris (0906) VM, so I don't know if maybe/probably the pattern
should match a broader range of solaris hosts. You can check by running
"iconv -l" and looking to see if it's included in the list of aliases or not.
bfd/ChangeLog:
PR binutils/11280
* configure.host (*-*-solaris2.11): Add host define to select
valid default code page for windres/windmc on solaris.
Ok for trunk?
cheers,
DaveK
--
(*) - http://sourceware.org/ml/binutils/2010-02/threads.html#00111
(**) - http://sourceware.org/bugzilla/show_bug.cgi?id=11280
? binutils/oops.diff
Index: bfd/configure.host
===================================================================
RCS file: /cvs/src/src/bfd/configure.host,v
retrieving revision 1.17
diff -p -u -r1.17 configure.host
--- bfd/configure.host 30 Dec 2005 22:25:57 -0000 1.17
+++ bfd/configure.host 14 Feb 2010 03:34:14 -0000
@@ -56,6 +56,8 @@ mips*-*-riscos*) HDEFINES="-G 4" ;;
m68*-hp-hpux*) HDEFINES=-DHOST_HP300HPUX ;;
+*-*-solaris2.11) HDEFINES=-DCP_ACP=1 ;;
+
*-*-windows*)
HOST_64BIT_TYPE=__int64
HOST_U_64BIT_TYPE="unsigned __int64"