This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Binutils 2.20 - Windres problems building pthreads/libiconv on Open Solaris


On 15/02/2010 10:15, Nick Clifton wrote:
> Hi Dave,
> 
>> Tony, the attached patch fixes the crash on my osol VM, would you like to
>>  give it a test?
> 
> This patch is approved for the mainline, although I would like to see a 
> comment describing why it is necessary to define CP_ACP, and possibly 
> referring the reader back to the PR.

  Applied with a comment like so and changelog as posted elswhere separately.
 Thanks!

    cheers,
      DaveK

Index: bfd/configure.host
===================================================================
RCS file: /cvs/src/src/bfd/configure.host,v
retrieving revision 1.17
diff -p -u -r1.17 configure.host
--- bfd/configure.host	30 Dec 2005 22:25:57 -0000	1.17
+++ bfd/configure.host	15 Feb 2010 19:23:30 -0000
@@ -56,6 +56,12 @@ mips*-*-riscos*)	HDEFINES="-G 4" ;;
 
 m68*-hp-hpux*)		HDEFINES=-DHOST_HP300HPUX ;;
 
+# Some Solaris systems (osol0906 at least) have a libc that doesn't recognise
+# the "MS-ANSI" code page name, so we define an override for CP_ACP (sets the
+# default code page used by windres/windmc when not specified by a commandline
+# option) to select the "WINDOWS-1252" name instead.  See PR11280 for details.
+*-*-solaris2.11)	HDEFINES=-DCP_ACP=1 ;;
+
 *-*-windows*)
 			HOST_64BIT_TYPE=__int64
 			HOST_U_64BIT_TYPE="unsigned __int64"

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]