This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA] PR9861 FAIL: EABI attributes from directives
- From: Daniel Jacobowitz <dan at codesourcery dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 19 Feb 2010 11:21:27 -0500
- Subject: Re: [RFA] PR9861 FAIL: EABI attributes from directives
- References: <1266589245.28369.24.camel@e102111-lin.cambridge.arm.com>
On Fri, Feb 19, 2010 at 02:20:45PM +0000, Matthew Gretton-Dann wrote:
> Hi,
>
> The attached patch fixes PR9861
> (http://sourceware.org/bugzilla/show_bug.cgi?id=9861).
>
> The issue is that the default CPU to assembler for (defined by
> CPU_DEFAULT) is dependent upon the compiler used to build gas. And so
> arm-unknown-linux-gnueabi-as will produce different results depending
> upon whether it is built on an x86_64 or an ARM machine (say).
>
> The proposed patch removed any definition of CPU_DEFAULT based upon
> build compiler predefines.
>
> I have tested this with the cross-product of
> (--target=arm-unknown-linux-gnueabi, --target=arm-none-eabi) and
> (--build=x86_64-unknown-linux-gnu, --build=armv7-unknown-linux-gnueabi).
>
> Can someone please review, and then if happy approve the patch?
I stumbled on the same issue recently and drew the same conclusion.
OK to commit, thanks!
--
Daniel Jacobowitz
CodeSourcery