This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD][PATCH PROPOSAL][ARM] fix the internal error in get_aeabi_object_attribute assert
- From: Ian Lance Taylor <iant at google dot com>
- To: vkutuzov at accesssoftek dot com
- Cc: Doug Kwan (éæå) <dougkwan at google dot com>, binutils <binutils at sourceware dot org>
- Date: Tue, 23 Feb 2010 09:45:59 -0800
- Subject: Re: [GOLD][PATCH PROPOSAL][ARM] fix the internal error in get_aeabi_object_attribute assert
- References: <1266868528.6817.55.camel@dp690-dev5v4>
Viktor Kutuzov <vkutuzov@accesssoftek.com> writes:
> this patch proposal fixes an internal error in the
> get_aeabi_object_attribute method by initializing an empty attribute
> section data in the Target_arm::do_finalize_section method in case it
> wasn't initialized before. This situation is occurred here if no
> existed input objects were passed into the linker. I got this situation
> when I passed a name for non-existed input object in the command line
> for the linker:
>
> arm-none-linux-gnueabi-ld missed-module.o -o module-out.o
>
> ../install.binutils.gold.crossarm/bin/arm-none-linux-gnueabi-ld:
> error: cannot open missed-module.o: No such file or directory
> ../install.binutils.gold.crossarm/bin/arm-none-linux-gnueabi-ld:
> internal error in get_aeabi_object_attribute, at ../../binutils.gold/src/gold/arm.cc:2386
Thanks. Approved and applied, with the following ChangeLog entry.
Ian
2010-02-23 Viktor Kutuzov <vkutuzov@accesssoftek.com>
* arm.cc (Target_arm::do_finalize_sections): Create attribute
section if it does not already exist.
* attributes.cc (Attributes_section_data::Attributes_section_data):
Don't crash if size is zero.