This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Fix slow sparc relocation lookup

From: Nick Clifton <nickc@redhat.com>
Date: Tue, 02 Mar 2010 07:33:30 +0000

> Hi David,
> 
>> 2010-03-01  David S. Miller<davem@davemloft.net>
>>
>> 	* elfxx-sparc.c (struct elf_reloc_map): Delete.
>> 	(sparc_reloc_map): Delete.
>> 	(_bfd_sparc_elf_reloc_type_lookup): Explicitly handle each
>> 	relocation type in switch statements.
> 
> Approved - please apply - although I would recommend adding a comment
> explaining that the switch table is used for efficiency so that some
> future programmer does not decide to replace it with a lookup table
> and a loop...

I'll add such a comment when I commit this, thanks Nick.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]