This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Support VER_FLG_INFO in readelf


Hi Nick,

>> While looking at Sun ld-generated executables with readelf, I noticed
>> that it doesn't support the VER_FLG_INFO flag.
>
> Am I correct in thinking that this flag is a Sun specific extension to the
> version flags ?  If so then:

I don't think you could call it that, given that Sun invented the symbol
versioning stuff back in Solaris 2.5 :-)  I'd still consider them the
source.  It just seems to be something the GNU community hasn't caught
up with when reimplementing that stuff.

>
>>  #define VER_FLG_BASE		0x1
>>  #define VER_FLG_WEAK		0x2
>> +#define VER_FLG_INFO		0x4
>
> You should add a comment to that effect here.

Ok, will do.  I've also prompted the Sun linker maintainers to properly
document the flag in the Object File-Format section of the Linkers and
Libraries Guide, so this should show up there sometime in the future.

> Other than that the changes to readelf.c and common.h are approved. I'll
> leave reviewing the gold/elfcpp changes to Ian.

Fine, thanks.  I'll wait with commiting till I hear from him.

Regards.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]