This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gold][patch] Control caching of memory mapped regions


> The patch is OK. ?It's also OK if you change the name.

I changed it to is_permanent_view() to eliminate the "!", and added a
comment to the method explaining the connection to DATA_NOT_OWNED.

Here's the patch as committed.

-cary

        * fileread.cc (File_read::~File_read): Don't delete whole_file_view_.
        (File_read::open[1]): Remove initial mapping of whole_file_view_.
        (File_read::open[2]): Add whole_file_view_ to list of views.
        (File_read::make_view): Remove test of whole_file_view_.
        (File_read::find_or_make_view): Create whole_file_view_ if
        necessary.
        (File_read::clear_views): Replace bool parameter with enum;
        adjust all callers.  Don't delete views with permanent data;
        do delete cached views and views from archives if
        --no-keep-files-mapped is set.  Set whole_file_view_ to NULL
        if clearing the corresponding view.
        * fileread.h (File_read::Clear_views_mode): New enum.
        (File_read::View::is_permanent_view): New method.
        (File_read::clear_views): Replace bool parameter
        with enum; adjust all callers.
        * options.h (General_options): Change keep_files_mapped option;
        add map_whole_files.
        * readsyms.cc (Add_symbols::run): Delete sd_ object before
        releasing the file.
        * reloc.cc (Scan_relocs::run): Delete rd_ object before releasing
        the file.

Attachment: gold-no-keep-patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]