This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][GOLD] Make string offset assignment independent of implementation of unordered map elements order.

From: =?big5?b?RG91ZyBLd2FuICjD9q62vHcp?= <dougkwan at google dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: binutils <binutils at sourceware dot org>
Date: Sun, 14 Mar 2010 22:21:15 -0700
Subject: Re: [PATCH][GOLD] Make string offset assignment independent of implementation of unordered map elements order.
References: <498552561003131533p2d33a84dh2a2b30262908524c@mail.gmail.com> <mcrwrxefed2.fsf@dhcp-172-17-9-151.mtv.corp.google.com>

2010/3/14 Ian Lance Taylor <iant@google.com>:

> The stringpool code is pretty time intensive for the linker, so I'm
> not thrilled about walking the hash table twice. ?When not optimizing,
> I think we can actually calculate key_to_offset_ as we add strings to
> the table. ?That's even better, since we can eliminate the hash table
> walk. ?How does that sound?

That's better. I can submit another patch.

-Doug

Follow-Ups:
- Re: [PATCH][GOLD] Make string offset assignment independent of implementation of unordered map elements order.
  - From: =?big5?b?RG91ZyBLd2FuICjD9q62vHcp?=

References:
- [PATCH][GOLD] Make string offset assignment independent of implementation of unordered map elements order.
  - From: =?big5?b?RG91ZyBLd2FuICjD9q62vHcp?=
- Re: [PATCH][GOLD] Make string offset assignment independent of implementation of unordered map elements order.
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]