This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA] Fix an i386 ld test FAIL
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jie Zhang <jie at codesourcery dot com>
- Cc: binutils <binutils at sourceware dot org>
- Date: Wed, 17 Mar 2010 05:52:39 -0800
- Subject: Re: [RFA] Fix an i386 ld test FAIL
- References: <4BA0BA96.7060600@codesourcery.com>
On Wed, Mar 17, 2010 at 3:18 AM, Jie Zhang <jie@codesourcery.com> wrote:
> This patch fixes "Invalid allocated section" test in
> ld/testsuite/ld-i386/i386.exp when testing ld on native i686-pc-linux-gnu.
>
> This test case consumes all the 1G memory + 1G swap when testing on my 32bit
> i686 PC and finally times out.
>
> For the section .foo in that test case, sec->vma == 0 and p->p_vaddr +
> p->p_memsz == 0xc0100008. So in the following statement:
>
> ?bfd_signed_vma adjust = sec->vma - (p->p_vaddr + p->p_memsz);
>
> adjust is 0x3feffff8 because we are doing 32bit calculation. Thus the
> expected "overlaps preious sections" error is not reported.
>
> Regtested with native i686-pc-linux-gnu. Is this patch OK?
>
Thanks for fixing it. I checked it as an obvious fix.
--
H.J.