This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch bfd]: Win32 coff-i386 and coff-x86_64 broken in_reloc_p


On 30/03/2010 14:54, Kai Tietz wrote:


>         * coff-i386.c (in_reloc_p): Check also for R_SECREL32.
>         * coff-x86_64.c (in_reloc_p): Check also for R_AMD64_IMAGEBASE.

>         * binutils-all/objcopy.exp: Mark simple copy executable
>         as failing for all *-*-mingw32* targets.
> 
> Patch tested for i686-pc-cygwin, i686-pc-mingw32, and x86_64-pc-mingw32. 
> Ok for apply?

  The second one is OK.  The first, I want a testcase for before you commit
it.  A simple dump test will do (e.g using "objdump -b binary -s" on the
generated base file), anything's an improvement on the current situation where
we have no testing of the --base-file option at all.

    cheers,
      DaveK






Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]