This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch bfd]: Win32 coff-i386 and coff-x86_64 broken in_reloc_p
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Kai Tietz <Kai dot Tietz at onevision dot com>
- Cc: binutils at sourceware dot org, Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Date: Tue, 30 Mar 2010 17:35:18 +0100
- Subject: Re: [patch bfd]: Win32 coff-i386 and coff-x86_64 broken in_reloc_p
- References: <OF6C3B9D80.76D5AF51-ONC12576F6.004BAD63-C12576F6.004C6C1D@onevision.de>
On 30/03/2010 14:54, Kai Tietz wrote:
> * coff-i386.c (in_reloc_p): Check also for R_SECREL32.
> * coff-x86_64.c (in_reloc_p): Check also for R_AMD64_IMAGEBASE.
> * binutils-all/objcopy.exp: Mark simple copy executable
> as failing for all *-*-mingw32* targets.
>
> Patch tested for i686-pc-cygwin, i686-pc-mingw32, and x86_64-pc-mingw32.
> Ok for apply?
The second one is OK. The first, I want a testcase for before you commit
it. A simple dump test will do (e.g using "objdump -b binary -s" on the
generated base file), anything's an improvement on the current situation where
we have no testing of the --base-file option at all.
cheers,
DaveK