This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, ARM] Handle non-core registers in GAS' CFI statement parser

From: Nick Clifton <nickc at redhat dot com>
To: Thomas Schwinge <thomas at codesourcery dot com>
Cc: binutils at sourceware dot org
Date: Tue, 06 Apr 2010 12:56:37 +0100
Subject: Re: [PATCH, ARM] Handle non-core registers in GAS' CFI statement parser
References: <87wrwrxpqa.fsf@dirichlet.schwinge.homeip.net>

Hi Thomas,

gas/
2010-03-26  Thomas Schwinge<thomas@codesourcery.com>

	* config/tc-arm.c (tc_arm_regname_to_dw2regnum): Re-implement in order
	to also handle non-core registers.

Approved - but please could you also create a test case to check this new behaviour please.

-  if (reg == FAIL)
+  if (!reg)
      return -1;

This is just my opinion here but I would suggest testing "if (reg == NULL)" here since I think that it makes it clearer that reg is a pointer not an integer.

Cheers
  Nick

References:
- [PATCH, ARM] Handle non-core registers in GAS' CFI statement parser
  - From: Thomas Schwinge

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]