This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch 2/4] Rewrite of the alpha-vms bfd back-end (bfd)

On Apr 13, 2010, at 1:12 PM, Nick Clifton wrote:

> Hi Tristan,

[...]
> 
> Approved - please apply.

Thanks, committed with the suggested improvements.

Tristan.

> 
> Some comments:
> 
> +/* Read & process EIHD record.
> +   Return 0 on success, -1 on error  */
> +
> +static int
> +_bfd_vms_slurp_eihd (bfd *abfd, unsigned int *eisd_offset,
> +                     unsigned int *eihs_offset)
> 
> Why not use bfd_boolean as the return type here ?  (And for other, similar functions ...)
> 
> 
> +	  sprintf (name, "$%s_%03d$", pfx, section_count++);
> 
> Is it (theoretically) possible to have more than 999 EISD records ?  If so then maybe an assertion or range check would be appropriate here.
> 
> 
> Cheers
>  Nick
>
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]