This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [arm] branches to weak symbols

From: Nick Clifton <nickc at redhat dot com>
To: Nathan Sidwell <nathan at codesourcery dot com>
Cc: binutils <binutils at sources dot redhat dot com>, Paul Brook <paul at codesourcery dot com>
Date: Thu, 29 Apr 2010 15:45:24 +0100
Subject: Re: [arm] branches to weak symbols
References: <4BD7F68D.9070102@codesourcery.com>

Hi Nathan,

This patch fixes some arm cases where the assembler did not consider
that a weakly defined symbol might be overridden in the final link.

2010-04-28 Nathan Sidwell <nathan@codesourcery.com>

	* write.c (fixup_segment): Do not assume we know the section a
	defined weak symbol is in.
	* config/tc-arm.c (relax_adr, relax_branch, md_apply_fix): Treat
	weak symbols as not known to be in the same section, even if they
	are defined.

	testsuite/
	* gas/arm/weakdef-1.s: New.
	* gas/arm/weakdef-1.d: New.
	* gas/arm/weakdef-2.s: New.
	* gas/arm/weakdef-2.d: New.
	* gas/arm/weakdef-2.l: New.

Approved and applied. Note - I made one small change which was to disable the new tests for non-ELF targeted ARM toolchains.

Cheers
  Nick

References:
- [arm] branches to weak symbols
  - From: Nathan Sidwell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]