RE: external vms_convert_to_var_unix_filename (just because it is static) and globalref

[Jay K <jay dot krell at cornell dot edu>]

oops, now with -Werror back:

cc1: warnings being treated as errors
/src/binutils/src/bfd/vms-alpha.c: In function 'alpha_vms_write_exec':
/src/binutils/src/bfd/vms-alpha.c:2868:16: error: comparison between signed and unsigned integer expressions
/src/binutils/src/bfd/vms-alpha.c: In function 'vms_close_and_cleanup':
/src/binutils/src/bfd/vms-alpha.c:8727:7: error: implicit declaration of function 'vms_convert_to_var_unix_filename'


?- Jay



----------------------------------------
> From: jay.krell@cornell.edu
> To: binutils@sourceware.org
> Subject: external vms_convert_to_var_unix_filename (just because it is static) and globalref
> Date: Sat, 8 May 2010 03:44:06 +0000
>
>
> /bin/sh ./libtool --tag=CC   --mode=link alpha-dec-vms-gcc -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g   -o size size.obj bucomm.obj version.obj filemode.obj ../bfd/libbfd.la ../libiberty/libiberty.a
> libtool: link: alpha-dec-vms-gcc -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -o size size.obj bucomm.obj version.obj filemode.obj  ../bfd/.libs/libbfd.a ../libiberty/libiberty.a
> ../bfd/.libs/libbfd.a(vms-alpha):($DATA$+0xdee8): undefined reference to `vms_convert_to_var_unix_filename'
> collect2: ld returned 1 exit status
> make[4]: *** [size] Error 1
> make[3]: *** [all-recursive] Error 1
> make[2]: *** [all] Error 2
> make[1]: *** [all-binutils] Error 2
> make: *** [all] Error 2
>
>
> and workaround presence of "globalref" in VMS system headers.
>
>
> The use of vms_convert_to_var_unix_filename is in vms-alpha.c.
> I don't know if this works, just that compile/link gets further.
>
>
> jbook2:bfd jay$ cvs -z3 diff -u vms-misc.c
> Index: vms-misc.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/vms-misc.c,v
> retrieving revision 1.33
> diff -u -r1.33 vms-misc.c
> --- vms-misc.c    14 Apr 2010 09:24:59 -0000    1.33
> +++ vms-misc.c    8 May 2010 01:11:33 -0000
> @@ -22,6 +22,10 @@
>     Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
>     MA 02110-1301, USA.  */
>
> +#if defined(__vms) && defined(__GNUC__) && !defined(globalref)
> +#define globalref extern
> +#endif
> +
>  #if __STDC__
>  #include 
>  #endif
> @@ -431,7 +435,7 @@
>     using undocumented system call sys$modify().
>     Unix filename version.  */
>
> -static int
> +int
>  vms_convert_to_var_unix_filename (const char *unix_filename)
>  {
>    if (decc$to_vms (unix_filename, &vms_convert_to_var_1, 0, 1) != 1)
>
>
>
>  - Jay
>
>
>
>