Re: [PATCH] SH-2A FDPIC Support

[Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>]

Andrew Stubbs <ams@codesourcery.com> wrote:
> The attached patch implements FDPIC support for SH-2A uClinux.
> 
> The ABI has been published here:
> http://www.codesourcery.com/public/docs/sh-fdpic/sh-fdpic-abi.txt
> 
> The implementation is not perfect (there are still a number of FIXMEs 
> and such), but it is functional. I have successfully built a working 
> uClinux system (incorporating busybox and dynamically linked uClibc), 
> and the Binutils and GCC testsuites run tolerably well.
> 
> GCC and uClibc patches will follow soon.
> 
> OK to apply?

All SH specific parts are OK.  Thanks for this work!
If the linker testcases Joseph pointed out are SH specific,
they are pre-approved.

The last generic testsuite hunk

> --- a/src/binutils-mainline/ld/testsuite/lib/ld-lib.exp
> +++ b/src/binutils-mainline/ld/testsuite/lib/ld-lib.exp
> @@ -404,6 +404,7 @@ proc is_elf_format {} {
>  	 && ![istarget *-*-linux*] \
>  	 && ![istarget frv-*-uclinux*] \
>  	 && ![istarget bfin-*-uclinux] \
> ++ 	 && ![istarget sh*-*-uclinux*] \
   ^^

has an extra '+' (and a white space) which causes tcl errors
on my environment.

Regards,
	kaz