Re: [PATCH] ARM: Disassemble lsls #0 as movs in Thumb-1

[Richard Earnshaw <rearnsha at arm dot com>]

On Wed, 2010-06-02 at 14:44 +0100, Matthew Gretton-Dann wrote:
> On Wed, 2010-06-02 at 10:47 +0100, Richard Earnshaw wrote:
> > On Tue, 2010-06-01 at 16:29 +0100, Matthew Gretton-Dann wrote:
> > > diff --git a/gas/testsuite/gas/arm/thumb.s
> > > b/gas/testsuite/gas/arm/thumb.s
> > > index d1e4339..79cadd7 100644
> > > --- a/gas/testsuite/gas/arm/thumb.s
> > > +++ b/gas/testsuite/gas/arm/thumb.s
> > > @@ -200,3 +200,7 @@ forwardonly:
> > >  .target:
> > >         nop     @ pad for a.out
> > >         nop
> > > +
> > > +baz:
> > > +       mov     r0, r1
> > > +       
> > 
> > This bit isn't right: the nops that precede your new code are to pad the
> > object out to an even number of words (so that disassembly will be
> > consistent across all object formats).
> > 
> > Other than this, the patch is fine.
> 
> Please find attached a new version of the patch which corrects this.
> Now, instead of adding new instructions after the nops for .target I
> just replace one nop with the mov instruction.
> 

OK

R.