This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA] [ARM] Fix reporting of undefined and deprecated mov rd, rm instructions
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 30 Jun 2010 17:28:35 +0100
- Subject: Re: [RFA] [ARM] Fix reporting of undefined and deprecated mov rd, rm instructions
- References: <1277742450.9469.13.camel@e102319-lin.cambridge.arm.com>
On Mon, 2010-06-28 at 17:27 +0100, Matthew Gretton-Dann wrote:
> Hi,
>
> In Thumb state gas rejects mov sp, sp. In fact this instruction is
> allowed (but deprecated).
>
> The attached patch fixes this case, and other related cases where the
> disassembler was incorrectly accepting or rejecting variants of mov rd,
> rm in Thumb state. Please can someone review and if appropriate approve
> it?
>
> Thanks,
>
> Matt
>
> Proposed ChangeLogs:
>
> gas/ChangeLog:
> 2010-06-28 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * config/tc-arm.c (do_t_mov_cmp): Fix reporting of
> unpredictable and deprecated mov register instructions.
>
> gas/testsuite/ChangeLog:
> 2010-06-28 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * gas/arm/thumb2_bad_reg.s: Update mov register tests.
> * gas/arm/thumb2_bad_reg.l: Likewise.
This is OK.
R.