This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 9/9] MIPS/GAS: Correct MIPS16 HI16/LO16 reloc pairing
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: binutils at sourceware dot org, Catherine Moore <clm at codesourcery dot com>, gnu-mips-sgxx at codesourcery dot com
- Date: Sat, 03 Jul 2010 18:18:23 +0100
- Subject: Re: [PATCH 9/9] MIPS/GAS: Correct MIPS16 HI16/LO16 reloc pairing
- References: <alpine.DEB.1.10.1007021640060.2824@tp.orcam.me.uk>
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> 2010-07-02 Maciej W. Rozycki <macro@codesourcery.com>
>
> gas/
> * config/tc-mips.c (mips_frob_file): Use symbol_same_p to match
> symbols.
>
> gas/testsuite/
> * gas/mips/elf-rel27.d: New test for HI16/LO16 relocation
> pairing.
> * gas/mips/elf-rel27.s: Source for the new test.
> * gas/mips/mips.exp: Create "mips16" architecture. Define
> "mips" property. Adjust conditions involving negated properties
> throughout to require "mips1" as appropriate. Run the new test.
> (mips_arch_destroy): New procedure.
The tc-mips.c change is OK. I'm not sure about the "mips" property
though. Why not just use [mips_arch_list_all]?
Richard