This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch gas]: Fix of aligncomm to allow any kind of symbol names
2010/7/11 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 10/07/2010 18:57, Kai Tietz wrote:
>> 2010/7/10 Kai Tietz <ktietz70@googlemail.com>:
>>> Hello,
>>>
>>> caused by research for PR ld/11612 I found that the underlying issue
>>> is in gas/config/obj-coff.c in function obj_common_parse. As the
>>> function symbol name isn't quoted, it can lead to conflicts with
>>> def-file parser keywords. By quoting the symbol-name by ', issue is
>>> solved.
>
>>> ? ? ? ?PR ld/11612
>>> ? ? ? ?* config/obj-coff.c (obj_common_parse): Quote symbol-name.
>>>
>>> Tested for i686-pc-cygwin, i686-pc-mingw32, and x86_64-pc-mingw32. Ok for apply?
>
>> ChangeLog for gas/testsuite/gas/
>>
>> ? ? ? ? * pe/aligncomm-b.d: Regenerated content dump.
>> ? ? ? ? * pe/aligncomm-d,d: Regenerated content dump.
>> ? ? ? ? * i386/i386.exp: Disable for mingw 64-bit the intel-got64 test.
>>
>> Ok for apply?
>
> ?I've just been reading MSDN:
>
> http://msdn.microsoft.com/en-us/library/h41zhe21(v=VS.80).aspx
>
> ?I think it suggests that the standard format for quoting should use double
> quote marks, so the fact of our tools accepting single quotes is probably a
> GNU extension. ?Given that, could you change both this patch and your GCC
> patch to use double instead of single quotes? ?OK with that change.
>
> ? ?cheers,
> ? ? ?DaveK
>
>
Right, the single quote looks like a gnu extension. As those
directives are gnu-extensions anyway, I choose single-quote. I changed
patch to use instead double-quote and apply it soon.
Regards,
Kai
--
|? (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination