This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][GOLD] Use correct local symbol values in stub generation.


"Doug Kwan (éæå)" <dougkwan@google.com> writes:

>     Attached is an updated patch.  I changed the interface to that
> compute_final_local_value takes two pointers, one for input and the
> other output symbol value.  I also renamed the inline function and
> fixed the indentation.

> +// Compute the final value of a local symbol.  This code used to be
> +// in the loop body of do_finalize_local_symbols.  It was extracted into
> +// a seperate method so that we can share it between do_finalize_local_symbols
> +// and the public version of this method.

You only need the first sentence of this comment.  The rest of the
comment is not useful going forward.

This is OK with that change.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]