This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch gas/testsuite SEH x64]: Some initial tests about SEH pseudo-operators


2010/9/12 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 12/09/2010 10:43, Kai Tietz wrote:
>> Hello,
>>
>> this patch adds some x64 SEH related tests to gas' testsuite.
>
> ?Thank you! ?Even these kinds of trivial smoke-tests are worthwhile.
>
>> ChangeLog
>>
>> 2010-09-12 ?Kai Tietz
>>
>> ? ? ? ? ? * /gas/pe/pe_seh.exp: New.
>> ? ? ? ? ? * /gas/pe/peseh-x64.s: New.
>> ? ? ? ? ? * /gas/pe/peseh-x64.d: New.
>> ? ? ? ? ? * /gas/pe/peseh-x64-2.s: New.
>> ? ? ? ? ? * /gas/pe/peseh-x64-2.d: New.
>> ? ? ? ? ? * /gas/pe/peseh-x64-3.s: New.
>> ? ? ? ? ? * /gas/pe/peseh-x64-3.d: New.
>>
>> Tested for x86_64-w64-mingw32 and for i686-pc-cygwin. Ok for apply?
>
> ?Please let's not multiply expect scripts unnecessarily. ?I can't think of
> any reason not to just tag the "if ([istarget "x86_64-*-mingw*"])" clause onto
> the end of the existing gas/pe/pe.exp, so OK with that change. ?Also, don't
> forget to remove those leading slashes from the filenames in your changelog
> entry when you check it in.
>
> ? ?cheers,
> ? ? ?DaveK
>
>

Hmm, I think it is worth having here a separate .exp script. SEH is
present for other PE-COFF targets, too. And so tests of features
should be grouped IMHO.
What make you think that it is better to have just on giant .exp files
containing everything unsorted?

Cheers,
Kai

PS: Thanks for the catch of those leading /


-- 
|? (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]