This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH ARM 3/6]: Architectural Extensions - Security Extensions


On Thu, 2010-09-23 at 10:20 +0100, Matthew Gretton-Dann wrote:
> gas/ChangeLog:
> 2010-09-22  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* config/tc-arm.c (arm_ext_v6z): Remove.
> 	(arm_ext_sec): Add.
> 	(do_t_smc): In Thumb state SMC requires v7-A.
> 	(insns): Make SMC depend on Security Extensions.
> 	(arm_cpus): All -mcpu=cortex-a* options have the Security 
> 	Extensions.
> 	(arm_extensions): Add 'sec' extension.
> 	(cpu_arch_ver): Reorder.
> 	(aeabi_set_public_attributes): Emit Tag_Virtualization_use as
> 	appropriate.
> 	* doc/c-arm.texi: Document Security Extensions.
> 
> gas/testsuite/ChangeLog:
> 2010-09-22  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* gas/arm/attr-march-all.d: Update for Security Extensions..
> 	* gas/arm/attr-march-armv6k+sec.d: New test.
> 	* gas/arm/attr-march-armv6z.d: Update for Security Extensions.
> 	* gas/arm/attr-march-armv6zk.d: Likewise.
> 	* gas/arm/attr-march-armv6zkt2.d: Likewise.
> 	* gas/arm/attr-march-armv6zt2.d: Likewise.
> 	* gas/arm/attr-march-armv7-a+sec.d: New test.
> 	* gas/arm/attr-mcpu.d: Update for Security Extensions.
> 	* gas/arm/thumb32.d: Likewise.
> 	* gas/arm/thumb32.s: Likewise.
> 
> include/opcode/ChangeLog:
> 2010-09-22  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* arm.h (ARM_EXT_V6Z): Remove.
> 	(ARM_EXT_SEC): Add.
> 	(ARM_AEXT_V6Z): Use Security Extensions.
> 	(ARM_AEXT_V6ZK): Likeiwse.
> 	(ARM_AEXT_V6ZT2): Likewise.
> 	(ARM_AEXT_V6ZKT2): Likewise.
> 	(ARM_AEXT_V7_ARM): Base v7 does not have Security Extensions.
> 	(ARM_ARCH_V7A_SEC): Add.
> 	(ARM_ARCH_V7A_MP): Rename...
> 	(ARM_ARCH_V7A_MP_SEC): ...to this and add Security Extensions.
> 
> ld/testsuite/ChangeLog:
> 2010-09-22  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* ld-arm/attr-merge-6.attr: Update for Security Extensions.
> 	* ld-arm/attr-merge-7.attr: Likewise.
> 
> opcodes/ChangeLog:
> 2010-09-22  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* arm-dis.c (arm_opcodes): SMC implies Security Extensions.
> 	(thumb32_opcodes): Likewise.

So
>	(arm_ext_sec): Add.

Should be written as

	(arm_ext_sec): New {variable,function,enum,define,...}.

saying whatever type of object is being added.  There are several cases like this.

Otherwise OK

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]