This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH 1/2] gas: blackfin: fix LOOP_BEGIN/LOOP_END pseudo insns handling of local labels
- From: Mike Frysinger <vapier at gentoo dot org>
- To: binutils at sourceware dot org
- Cc: David Gibson <david dot gibson at analog dot com>
- Date: Sun, 10 Oct 2010 03:48:13 -0400
- Subject: [PATCH 1/2] gas: blackfin: fix LOOP_BEGIN/LOOP_END pseudo insns handling of local labels
From: David Gibson <david.gibson@analog.com>
The current LOOP_BEGIN/LOOP_END pseudo insns hit "Internal errors" when
using local labels as the loop names due to attempts at removing them.
Signed-off-by: David Gibson <david.gibson@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2010-09-10 David Gibson <david.gibson@analog.com>
* config/tc-bfin.c (bfin_gen_loop): Check symbol before removing.
---
gas/config/tc-bfin.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/gas/config/tc-bfin.c b/gas/config/tc-bfin.c
index ccd14cb..e854dce 100644
--- a/gas/config/tc-bfin.c
+++ b/gas/config/tc-bfin.c
@@ -1874,6 +1874,7 @@ bfin_gen_loop (Expr_Node *exp, REG_T reg, int rop, REG_T preg)
char *lbeginsym, *lendsym;
Expr_Node_Value lbeginval, lendval;
Expr_Node *lbegin, *lend;
+ symbolS *sym;
loopsym = exp->value.s_value;
lbeginsym = (char *) xmalloc (strlen (loopsym) + strlen ("__BEGIN") + 5);
@@ -1896,9 +1897,11 @@ bfin_gen_loop (Expr_Node *exp, REG_T reg, int rop, REG_T preg)
lbegin = Expr_Node_Create (Expr_Node_Reloc, lbeginval, NULL, NULL);
lend = Expr_Node_Create (Expr_Node_Reloc, lendval, NULL, NULL);
- symbol_remove (symbol_find (loopsym), &symbol_rootP, &symbol_lastP);
+ sym = symbol_find(loopsym);
+ if (!S_IS_LOCAL (sym) || (S_IS_LOCAL (sym) && !symbol_used_p (sym)))
+ symbol_remove (sym, &symbol_rootP, &symbol_lastP);
- return bfin_gen_loopsetup(lbegin, reg, rop, lend, preg);
+ return bfin_gen_loopsetup (lbegin, reg, rop, lend, preg);
}
void
--
1.7.3