This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix oopsie in ld-plugin tests.
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: dave dot korn dot cygwin at gmail dot com
- Cc: hp at axis dot com, binutils at sourceware dot org
- Date: Fri, 15 Oct 2010 21:02:06 +0200
- Subject: Re: [PATCH] Fix oopsie in ld-plugin tests.
> Date: Fri, 15 Oct 2010 20:18:21 +0100
> From: Dave Korn <dave.korn.cygwin@gmail.com>
> On 15/10/2010 19:10, Hans-Peter Nilsson wrote:
> >> Date: Thu, 14 Oct 2010 06:24:04 +0100
> >> From: Dave Korn <dave.korn.cygwin@gmail.com>
> >
> >> ld/testsuite/ChangeLog:
> >>
> >> * ld-plugin/plugin.exp: Don't error out if there is no target compiler
> >> available, make tests UNSUPPORTED instead.
> >
> >> +if { !$can_compile || $failed_compile } {
> >> foreach testitem $plugin_tests {
> >> unresolved [lindex $testitem 0]
> >
> > Incorrect, or you sent and committed the wrong patch. You made
> > them UNRESOLVED, which causes make to (still) return an error.
>
> Sorry, that was what you suggested in your off-list email. Did you mean to
> says UNSUPPORTED perhaps?
Yes, as I also mentioned off-list, presumably after you sent this. :)
(and the patch didn't match the ChangeLog; UNSUPPORTED != UNRESOLVED)
Right, too many choices!
brgds, H-P