This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gold patch] Fix problem with alignment of relro sections


> Hmmm, not quite there yet... if there's anything in .tdata or .tbss,
> it'll prevent us from doing the relro alignment. Need to tweak it
> slightly to take that into account.

I also needed to put the alignment padding before .got instead of
between .got and .got.plt.

This patch ignores TLS sections when checking whether the first
section is a relro section, accounts for the alignment padding for the
TLS segment when computing the size of the relro segment, and puts
alignment padding before the ORDER_RELRO_LAST section (.got).

OK?

-cary

        * output.h (Output_segment::set_section_addresses): Change function
        signature.  Update all callers.
        * output.cc (Output_segment::is_first_section_relro): Ignore TLS
        sections.
        (Output_segment::set_section_addresses): Align after last TLS
        section.  Add padding before last relro section instead of after.

Attachment: gold-relro-tls-patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]