This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR binutils/12280: Makefiles don't support LTO


On Wed, Dec 1, 2010 at 11:15 PM, Ralf Wildenhues <Ralf.Wildenhues@gmx.de> wrote:
> Hello H.J.,
>
> * H.J. Lu wrote on Thu, Dec 02, 2010 at 06:34:56AM CET:
>> This patch adds + to LINK in Makefile for GNU make. ?OK for trunk?
>
>> diff --git a/config/gnumake.m4 b/config/gnumake.m4
>> new file mode 100644
>> index 0000000..2d21e12
>> --- /dev/null
>> +++ b/config/gnumake.m4
>> @@ -0,0 +1,22 @@
>> +dnl Placed after AC_OUTPUT to add `+' to LINK for GNU make.
>
> That is not reliable: a config.status run updating Makefile may be
> triggered from make rules, by-passing configure completely.
>
> Also, $(LINK) is not the only link-related variable, there can be
> prog_LINK for programs and libraries.
>
> The common way to do this is to have a new config.status action (which
> however is also not recheck-safe) or to tack it onto the existing
> Makefile action; e.g.:
>
> AC_CONFIG_FILES([Makefile], [sed ... Makefile ...])
>
> But why not go a different (and IMVHO simpler) route completely: have a
> variable $(LTO) or so that expands to empty, or to '+' if LTO is used,
> and then prepending that to *LINK values unconditionally.
> That has the advantage that you can still get 'make -n' right if using
> GNU make but not LTO.
>

Here is a new patch.  OK for trunk?

Thanks.


-- 
H.J.
---
bfd/

2010-12-02  H.J. Lu  <hongjiu.lu@intel.com>

	PR binutils/12280
	* Makefile.am (@gnu_make@LIBTOOL): New.

	* configure.in: Add AM_GNU_MAKE.

	* Makefile.in: Regenerated.
	* aclocal.m4: Likewise.
	* configure: Likewise.

	* doc/Makefile.am (@gnu_make@override CC_FOR_BUILD): New.
	* doc/Makefile.in: Regenerated.

binutils/

2010-12-02  H.J. Lu  <hongjiu.lu@intel.com>

	PR binutils/12280
	* Makefile.am (@gnu_make@LIBTOOL): New.

	* configure.in: Add AM_GNU_MAKE.

	* Makefile.in: Regenerated.
	* aclocal.m4: Likewise.
	* configure: Likewise.

config/

2010-12-02  H.J. Lu  <hongjiu.lu@intel.com>

	PR binutils/12280
	* gnumake.m4: New.

gas/

2010-12-02  H.J. Lu  <hongjiu.lu@intel.com>

	PR binutils/12280
	* Makefile.am (@gnu_make@LIBTOOL): New.

	* configure.in: Add AM_GNU_MAKE.

	* Makefile.in: Regenerated.
	* aclocal.m4: Likewise.
	* configure: Likewise.

gold/

2010-12-02  H.J. Lu  <hongjiu.lu@intel.com>

	PR binutils/12280
	* Makefile.am (@gnu_make@override CC): New.
	(@gnu_make@override CXX): Likewise.

	* configure.ac: Add AM_GNU_MAKE.

	* Makefile.in: Regenerated.
	* aclocal.m4: Regenerated.
	* configure: Likewise.

gprof/

2010-12-02  H.J. Lu  <hongjiu.lu@intel.com>

	PR binutils/12280
	* Makefile.am (@gnu_make@LIBTOOL): New.

	* configure.in: Add AM_GNU_MAKE.

	* Makefile.in: Regenerated.
	* aclocal.m4: Likewise.
	* configure: Likewise.
ld/

2010-12-02  H.J. Lu  <hongjiu.lu@intel.com>

	PR binutils/12280
	* Makefile.am (@gnu_make@LIBTOOL): New.

	* configure.in: Add AM_GNU_MAKE.

	* Makefile.in: Regenerated.
	* aclocal.m4: Likewise.
	* configure: Likewise.

opcodes/

2010-12-02  H.J. Lu  <hongjiu.lu@intel.com>

	PR binutils/12280
	* Makefile.am (@gnu_make@LIBTOOL): New.
	(@gnu_make@override CC_FOR_BUILD): Likewise.

	* configure.in: Add AM_GNU_MAKE.

	* Makefile.in: Regenerated.
	* aclocal.m4: Likewise.
	* configure: Likewise.

Attachment: binutils-12280-2.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]