This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/12288: No newline at the end of diagnostic messages
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Binutils <binutils at sourceware dot org>
- Date: Sun, 5 Dec 2010 18:30:18 -0800
- Subject: Re: PATCH: PR ld/12288: No newline at the end of diagnostic messages
- References: <20101206010051.GA5881@intel.com>
On Sun, Dec 5, 2010 at 5:00 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Hi,
>
> The plugin diagnostic text doesn't have the trailing `\n'. ?I checked in
> this patch to add the trailing `\n' similar to gold.
>
>
> H.J.
> ---
> diff --git a/ld/ChangeLog b/ld/ChangeLog
> index bb7b5a6..4aed58c 100644
> --- a/ld/ChangeLog
> +++ b/ld/ChangeLog
> @@ -1,5 +1,10 @@
> ?2010-12-05 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> + ? ? ? PR ld/12288
> + ? ? ? * plugin.c (message): Add the trailing `\n'.
> +
> +2010-12-05 ?H.J. Lu ?<hongjiu.lu@intel.com>
> +
> ? ? ? ?* ldfile.c (ldfile_open_file_search): Check maybe_archive instead
> ? ? ? ?of is_archive.
> ? ? ? ?* emultempl/aix.em: Likewise.
I checked in this patch to add a space after `:' in plugin error message.
H.J.
--
diff --git a/ld/ChangeLog b/ld/ChangeLog
index eeefd33..63858ee 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,5 +1,9 @@
2010-12-05 H.J. Lu <hongjiu.lu@intel.com>
+ * plugin.c (message): Add a space after `:' in error message.
+
+2010-12-05 H.J. Lu <hongjiu.lu@intel.com>
+
* plugin.c (asymbol_from_plugin_symbol): Add the trailing `\n'
to einfo.
(get_symbols): Likewise.
diff --git a/ld/plugin.c b/ld/plugin.c
index 8c919b6..34d76bd 100644
--- a/ld/plugin.c
+++ b/ld/plugin.c
@@ -587,7 +587,8 @@ message (int level, const char *format, ...)
case LDPL_ERROR:
default:
{
- char *newfmt = ACONCAT ((level == LDPL_FATAL ? "%P%F:" : "%P%X:",
+ char *newfmt = ACONCAT ((level == LDPL_FATAL
+ ? "%P%F: " : "%P%X: ",
format, "\n", NULL));
vfinfo (stderr, newfmt, args, TRUE);
}