This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 10/20] MIPS/GAS: Fail on 64-bit addresses used with LI
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Catherine Moore <clm at codesourcery dot com>, binutils at sourceware dot org
- Date: Tue, 07 Dec 2010 10:25:05 +0000
- Subject: Re: [PATCH 10/20] MIPS/GAS: Fail on 64-bit addresses used with LI
- References: <alpine.DEB.1.10.1012020114000.14129@tp.orcam.me.uk>
Patch 9 is OK.
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> binutils-gas-mips-lidd-assert.diff
> Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
> ===================================================================
> --- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2010-12-01 21:05:50.000000000 +0000
> +++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2010-12-01 21:05:51.000000000 +0000
> @@ -7039,6 +7039,7 @@ macro (struct mips_cl_insn *ip)
> else
> {
> /* FIXME: This won't work for a 64 bit address. */
> + gas_assert (HAVE_32BIT_ADDRESSES);
> macro_build_lui (&offset_expr, AT);
> }
>
Not OK. This trivially triggers for:
li.d $f2,1.1
assembled with -mabi=64 -G0.
Richard