This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Optimize add_archive_element call
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Sat, 11 Dec 2010 09:07:19 +1030
- Subject: Re: PATCH: Optimize add_archive_element call
- References: <20101210134844.GA26507@intel.com>
On Fri, Dec 10, 2010 at 05:48:44AM -0800, H.J. Lu wrote:
> Hi,
>
> Before we call add_archive_element, we set subsbfd to NULL and
> check if it is changed after add_archive_element returns. This
> patch sets subsbfd to the unchanged value and avoids the check.
> OK to install?
Why not get rid of subsbfd entirely?
if (! (*info->callbacks->add_archive_element)
(info, element, symdef->name, &element))
--
Alan Modra
Australia Development Lab, IBM