This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Optimize add_archive_element call


On Fri, Dec 10, 2010 at 05:48:44AM -0800, H.J. Lu wrote:
> Hi,
> 
> Before we call add_archive_element, we set subsbfd to NULL and
> check if it is changed after add_archive_element returns.  This
> patch sets subsbfd to the unchanged value and avoids the check.
> OK to install?

Why not get rid of subsbfd entirely?

	  if (! (*info->callbacks->add_archive_element)
				(info, element, symdef->name, &element))

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]